Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker issues #398

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Fix docker issues #398

merged 4 commits into from
Jul 13, 2023

Conversation

oliveromahony
Copy link
Contributor

Proposed changes

Some invalid make target references and an issue with the ubuntu dockerfile

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit b3b0b26
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/64aebb54b7c25900087e1010

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (54c8ef1) 67.27% compared to head (645cad8) 67.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
- Coverage   67.27%   67.24%   -0.04%     
==========================================
  Files         113      113              
  Lines       12727    12727              
==========================================
- Hits         8562     8558       -4     
- Misses       3593     3599       +6     
+ Partials      572      570       -2

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Dean-Coakley
Dean-Coakley approved these changes Jul 12, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@oliveromahony oliveromahony merged commit 3f17c2c into main Jul 13, 2023
@oliveromahony oliveromahony deleted the fix-docker-issues branch July 13, 2023 10:32
gallarda
gallarda reviewed Jul 13, 2023
View reviewed changes
scripts/docker/nginx-plus/ubuntu/Dockerfile
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use cat instead of cp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gallarda gallarda gallarda left review comments

@aphralG aphralG aphralG approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@dhurley dhurley dhurley approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
bug Something isn't working chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oliveromahony @codecov-commenter @dhurley @Dean-Coakley @gallarda @aphralG